Open
Conversation
CheezItMan
reviewed
Sep 14, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Jessica. You hit all the learning goals here. Take a look at my comments and let me know what questions you have.
Comment on lines
+16
to
+28
| case remove | ||
| when '[' | ||
| return false if array[i] != ']' | ||
| when ']' | ||
| return false if array[i] != '[' | ||
| when '{' | ||
| return false if array[i] != '}' | ||
| when '}' | ||
| return false if array[i] != '{' | ||
| when '(' | ||
| return false if array[i] != ')' | ||
| when ')' | ||
| return false if array[i] != '(' |
There was a problem hiding this comment.
Just a note that you can dry this up with a hash where they keys are the close braces and the values are the corresponding open braces.
return false if brace_hash[remove] != array.pop
Comment on lines
+11
to
+12
| if (@front == 0 && @rear == (@max_size - 1)) || | ||
| (@rear == ((@front - 1) % (@max_size - 1))) |
There was a problem hiding this comment.
Suggested change
| if (@front == 0 && @rear == (@max_size - 1)) || | |
| (@rear == ((@front - 1) % (@max_size - 1))) | |
| if (@front != -1 && @front == (@rear + 1) % @max_size |
Comment on lines
+14
to
+22
| elsif @front == -1 # Queue is empty | ||
| # initialize front and rear | ||
| @front += 1 | ||
| @rear += 1 | ||
| elsif (@rear == (@max_size - 1) && @front != 0) # rear needs to wrap around | ||
| @rear = 0 | ||
| else | ||
| @rear += 1 | ||
| end |
There was a problem hiding this comment.
This can be dried up with something like
Suggested change
| elsif @front == -1 # Queue is empty | |
| # initialize front and rear | |
| @front += 1 | |
| @rear += 1 | |
| elsif (@rear == (@max_size - 1) && @front != 0) # rear needs to wrap around | |
| @rear = 0 | |
| else | |
| @rear += 1 | |
| end | |
| else | |
| @rear = (@rear + 1) % @max_size | |
| end |
| @store[@rear] = element | ||
| end | ||
|
|
||
| def dequeue |
| return dequeue | ||
| end | ||
|
|
||
| def front |
| end | ||
|
|
||
| # get how many elements are in the array | ||
| def size |
| end | ||
| end | ||
|
|
||
| def empty? |
| @@ -1,19 +1,18 @@ | |||
| class Stack | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation